On Tue, Jun 19, 2018 at 7:46 PM, Daniel Drake <drake@xxxxxxxxxxxx> wrote: >> > Can we avoid those ugly castings? > Now kbd_led_set can continue being a correctly typed function pointer > for led_classdev.brightness_set. And from the code you are adding here > you can call __kbd_led_set directly with signed integer values, and > rely on correct bounds correction without ugly casts. > > Andy, what do you think? Thanks, Daniel for investigation. I'm fine with solution(s) that has no ugly casting and no regression on the hardware we support. -- With Best Regards, Andy Shevchenko
