On Mon, Jun 11, 2018 at 3:05 PM, Jiri Kosina <jikos@xxxxxxxxxx> wrote: > On Thu, 31 May 2018, Andy Shevchenko wrote: > >> On Tue, May 22, 2018 at 11:55 PM, Daniel Drake <drake@xxxxxxxxxxxx> wrote: >> > Export asus_wmi_evaluate_method() and related headers for use by other >> > drivers. >> > >> > hid-asus is going to use this to avoid advertising that it has a keyboard >> > backlight when the keyboard backlight is controlled via WMI. >> > >> >> I'm fine with this as long as Darren and Benjamin agree on the approach. >> >> Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >> >> One nitpick below. > > So I'll take both patches (this one with your ack) through hid.git, ok? As far as you are okay with new dependency to the HID driver (Personally I don't think it's a good idea, which I commented and proposed a better approach, i.e. #ifdef in header around exported function and properly prepared Kconfig dependency line in HID section) -- With Best Regards, Andy Shevchenko
