On Fri, Jun 8, 2018 at 11:12 AM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote: > Hi! I just found out that thinkpad_acpi.ko is not automatically loaded > on new ThinkPad T480s. Is there any reason for it? Manually calling > modprobe thinkpad_acpi is working fine, but I would expect that it > should be loaded automatically. > > Here is dmesg output after loading it manually: > > thinkpad_acpi: ThinkPad ACPI Extras v0.25 > thinkpad_acpi: http://ibm-acpi.sf.net/ > thinkpad_acpi: ThinkPad BIOS N22ET34W (1.11 ), EC unknown > thinkpad_acpi: Lenovo ThinkPad T480s, model 20L7S03000 > thinkpad_acpi: radio switch found; radios are enabled > thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver > thinkpad_acpi: Disabling thinkpad-acpi brightness events by default... > thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is unblocked > thinkpad_acpi: Standard ACPI backlight interface available, not loading native one Did you run depmod -a? Is it present in the output? There are three ways of enumeration as far as I can see from the driver's code: - by short driver name "tpacpi" (not likely our case) - by DMI matching (only for old BIOS'es) - by ACPI ID So, does the ACPI contain one of the listed IDs? #define TPACPI_ACPI_IBM_HKEY_HID "IBM0068" #define TPACPI_ACPI_LENOVO_HKEY_HID "LEN0068" #define TPACPI_ACPI_LENOVO_HKEY_V2_HID "LEN0268" ? -- With Best Regards, Andy Shevchenko