> -----Original Message----- > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > Sent: Friday, May 25, 2018 2:52 AM > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: andy.shevchenko@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx; > Michael Shych <michaelsh@xxxxxxxxxxxx>; ivecera@xxxxxxxxxx > Subject: Re: [PATCH v2 3/7] platform/mellanox: mlxreg-hotplug: add extra cycle > for hotplug work queue > > On Mon, May 07, 2018 at 06:48:51AM +0000, Vadim Pasternak wrote: > > Hi Vadim, > > > Add extra cycle for hotplug work queue to handle the case when a > > signal is It adds missed logic for signal acknowledge, by adding an > > extra run for received, but no specific signal assertion is detected. > > Such case theoretically can happen for example in case several units > > are removed or inserted at the same time. In this situation > > acknowledge for some signal can be missed at signal top aggreagation > > status level. The extra run will allow to handler to acknowledge the missed > signal. > > > > ... > > > > > Fixes: 07b89c2b2a5e ("platform/x86: Introduce support for Mellanox > > hotplug driver") > > This sha doesn't exist in mainline, I believe you are referring to: > > $ git l | grep "Introduce support for Mellanox hotplug" > 304887041d95 platform/x86: Introduce support for Mellanox hotplug driver > > While this was introduced in 4.10. There have been many changes since then, > with significant changes in the 4.17 cycle. I have not added the stable tag, please > let me know if you think this should be pushed to stable, and which of the > intervening patches you'd consider dependencies. Hi Darren, Thank you for review. I think it's worth pushing to stable. It doesn't depend one previous patches from the patchset, but possibly this one, which just fixes few comments in mlxreg-hotplug: platform/mellanox: mlxreg-hotplug: Document fixes for hotplug private data (commit 321089a4da2f6b20bb8af96354f76d260a4ca2c6 in testing branch). Thanks, Vadim. > > I've fixed the sha in the commit message, and queued for testing. > > Thanks, > > -- > Darren Hart > VMware Open Source Technology Center
