On Fri, Apr 20, 2018 at 12:42:11PM -0500, Mario Limonciello wrote: > As reported by Randy Dunlap: > >> WARNING: unmet direct dependencies detected for DELL_SMBIOS > >> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] > >> && (DCDBAS [=m] || > >> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n) > >> Selected by [y]: > >> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] > >> && DMI [=y] > >> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || > >> ACPI_VIDEO [=n]=n) > >> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y] > >> > > Right now it's possible to set dell laptop to compile in but this > causes dell-smbios to compile in which breaks if dcdbas is a module. > > Dell laptop shouldn't select dell-smbios anymore, but depend on it. Ugh. Indeed. One of the goals of the previous maelstrom of dell* kconfig depencency changes was to make it so DELL_LAPTOP was visible without having to toggle DELL_SMBIOS*. But, having "select DELL_SMBIOS" avoids the dependency check causing this failure (I'm surprised and dismayed this made it through all the config permutation testing this saw). I'll apply this patch, and I guess it should go to stable, and for the next version I think it's time for a new "CONFIG DELL_EXTRAS" which will allow us to default DELL_SMBIOS to y and make the menu more consistent. Thank you for the catch. Grrrrrr :-( -- Darren Hart VMware Open Source Technology Center
