On Mon, Apr 09, 2018 at 11:07:03AM +0300, Andy Shevchenko wrote: > On Sun, Apr 8, 2018 at 8:40 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Not only silead touchscreens need some extra info not available in the > > ACPI tables to work properly. X86 devices with a Chipone ICN8505 chip also > > need some DMI based extra configuration. > > > > There is no reason to have separate dmi config code per touchscreen > > controller vendor. This commit renames silead_dmi to a more generic > > touchscreen_dmi name (and Kconfig option) in preparation of adding > > info for tablets with an ICN8505 based touchscreen. > > > > Note there are no functional changes all code changes are limited to > > removing references to silead where these are no longer applicable. > > > > I have no objections from my side, though consider the following: > - I would like to be in sync with Darren on this > - make oldconfig will be broken after your change for existing users > - the usual pattern in kernel that we don't rename drivers; I guess > here we are on the safe side b/c this driver is used standalone > > Taking above into attention, and assuming it will go via some other tree, > Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> This driver is all kinds of a special case, so no objection here either. :-) -- Darren Hart VMware Open Source Technology Center
