On Tue, Mar 27, 2018 at 10:02:04AM +0000, Vadim Pasternak wrote: > Patch adds new ODM systems, matched according to DMI_BOARD_NAME. General nit. When writing your messages, please use the imperative (command) form. Rather than: "Patch adds" or "It changes" use the same form you use in the subject lines: "Add new ODM systems", "Fix struct field documentation", etc. Again, I've been rewriting these, but as a regular contributor, this will help reduce the overhead of reviewing your patches - good for you, good for me :-) > The supported ODM Ids are: VMOD0001, VMOD0002, VMOD0003, VMOD0004, > VMOD0005. It doesn't introduce new systems, but allows to > ODM companies to set DMI_BOARD_VENDOR and DMI_PRODUCT_NAME on > their own. It assumes that ODM company can't change DMI_BOARD_NAME. You said "it assumes that ODM companies can't change DMI_BOARD_NAME". Is that an assumption, or is that how ODMs work with Mellanox? -- Darren Hart VMware Open Source Technology Center
