On Mon, Apr 2, 2018 at 9:27 PM, Alexander Kappner <agk@xxxxxxxxxxx> wrote: > The Thinkpad P50 has 2 fans. Add the 2FAN quirk so the tpacpi driver > properly reports both fan speeds. > Because the P50 doesn't report the version of its EC controller, we need to > identify it by BIOS version (N1). I have pushed it with changes discussed to my review and testing queue, thanks! I'm not sure if you were about to send a new version (no need anymore), though for the next time, please be familiar with https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst (in particular, section 8). And additional information, we are using special prefixes for our subsystem, i.e. "platform/x86: $DRIVER_NAME: ". > Signed-off-by: Alexander Kappner <agk@xxxxxxxxxxx> > --- > drivers/platform/x86/thinkpad_acpi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index d5eaf3b1..ebdc300 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -8699,16 +8699,24 @@ static const struct attribute_group fan_attr_group = { > .ec = TPID(__id1, __id2), \ > .quirks = __quirks } > > +#define TPACPI_FAN_QL_BIOS(__id1, __id2, __quirks) \ > + { .vendor = PCI_VENDOR_ID_LENOVO, \ > + .bios = TPID(__id1, __id2), \ > + .ec = TPACPI_MATCH_ANY, \ > + .quirks = __quirks } > + > static const struct tpacpi_quirk fan_quirk_table[] __initconst = { > TPACPI_FAN_QI('1', 'Y', TPACPI_FAN_Q1), > TPACPI_FAN_QI('7', '8', TPACPI_FAN_Q1), > TPACPI_FAN_QI('7', '6', TPACPI_FAN_Q1), > TPACPI_FAN_QI('7', '0', TPACPI_FAN_Q1), > TPACPI_FAN_QL('7', 'M', TPACPI_FAN_2FAN), > + TPACPI_FAN_QL_BIOS('N', '1', TPACPI_FAN_2FAN) // Thinkpad P50 has 2 fans > }; > > #undef TPACPI_FAN_QL > #undef TPACPI_FAN_QI > +#undef TPACPI_FAN_QL_BIOS > > static int __init fan_init(struct ibm_init_struct *iibm) > { > -- > 2.1.4 > -- With Best Regards, Andy Shevchenko
