> Sent: Monday, March 26, 2018 at 5:34 AM > From: "João Paulo Rechi Vita" <jprvita@xxxxxxxxx> > To: "Darren Hart" <dvhart@xxxxxxxxxxxxx> > Cc: "Andy Shevchenko" <andriy.shevchenko@xxxxxxxxxxxxxxx>, "Corentin Chary" <corentin.chary@xxxxxxxxx>, acpi4asus-user <acpi4asus-user@xxxxxxxxxxxxxxxxxxxxx>, tasev.stefanoska@xxxxxxxxx, "Platform Driver" <platform-driver-x86@xxxxxxxxxxxxxxx>, "Dun Hum" <bitter.taste@xxxxxxx> > Subject: Re: Regression: airplane mode led is not working anymore on Asus UX31A , UX305FA and UX330 4.11-rc2 kernel > > > The patch series referred here intended to avoid having asus-wmi > driving the LED as a side-effect of saving the WLAN state, and letting > asus-wireless drive it. Without this patch the LED was reflecting the > WLAN state (ON when WLAN was enabled, OFF when WLAN was disabled) > instead of the airplane-mode state, which is wrong since the LED is > labeled with an airplane icon (and also comparing with the behavior on > Windows). Thus, this is not a regression. > On my laptop there's no airplane and windows did not treat the led as such (afair) even though the ATK4001 device is present. I'd also say it's a regression because the patch: 1) The led doesn't work as expected 2) The driver in the 4.9 series (used by Debian) uses 4/5 to turn off/on the led while this version of the ATK uses 0/1 instead (this has been fixed in a later version but was not backported) 3) The driver tries to free an invalid pointer when unloaded (see https://bugzilla.kernel.org/show_bug.cgi?id=196467 and https://bugzilla.kernel.org/show_bug.cgi?id=196097) Moreover, after some exploration using acpi_call, I've discovered that calling HSWC(2) (or OWGL) always returns zero no matter what the status of the LED is.
