On Tue, Feb 27, 2018 at 10:15:32PM +0100, Michał Kępień wrote: > This patch series is an attempt to organize all the named constants used > throughout fujitsu-laptop so that their names more clearly convey their > purpose: a set of prefixes is introduced to "map" constant names to > call_fext_func() parameters. > > The chosen constant naming patterns are a compromise between readability > and enabling longer conditional expressions to fit into the 80-character > line length limit. Some changes (like those in patches 4/7 and 5/7) may > be perceived as bikeshedding, so please just think of them as proposals, > not fixes. > > Finally, patch 7/7 again [1] proposes a set of helper functions which > seem to be making quite a difference in terms of code readability in > certain places (especially in long conditional expressions). YMMV, > though, feel free to disagree. > > This patch series should be applied on top of for-next as it builds on > the previous patch series I submitted. > > [1] https://www.spinics.net/lists/platform-driver-x86/msg11633.html > > drivers/platform/x86/fujitsu-laptop.c | 228 +++++++++++++++++++--------------- > 1 file changed, 127 insertions(+), 101 deletions(-) What I see here is an agreement on a simple integer listing for patch 1/7 per Andy's latest reply. 7/7 appears to address Andy's concerns in 6/7. I agree they KEY vs EVENT_HK is a bit of bikeshedding - but I don't have a preference and I think overall the code is more readable for this series. Based on feedback on a couple of the patches, a respin appears to be pending, so I'm marking this series as "changes requested" and will await the v2. Thanks, -- Darren Hart VMware Open Source Technology Center
