Re: [PATCH][V2] intel-hid: support KEY_ROTATE_LOCK_TOGGLE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 16, 2018 at 2:53 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Thu, Mar 15, 2018 at 04:23:41PM -0700, Alex Hung wrote:
>> KEY_ROTATE_LOCK_TOGGLE is introduced in 4.16 rc1 and this key event is
>> emitted on Wacom MobileStudio Pro 13.
>>
>> Signed-off-by: Alex Hung <alex.hung@xxxxxxxxxxxxx>
>> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
>
> Hey Alex,
>
> Who is the author?

Jason and I worked together - I was the original author but Jason
helped verified it and modified 0xC9 from KE_KEY to KE_IGNORED as it
is not needed.

>
>> ---
>>  drivers/platform/x86/intel-hid.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
>> index 5e3df194723e..93f62d0e2b47 100644
>> --- a/drivers/platform/x86/intel-hid.c
>> +++ b/drivers/platform/x86/intel-hid.c
>> @@ -67,8 +67,8 @@ static const struct key_entry intel_array_keymap[] = {
>>       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },                /* Release */
>>       { KE_KEY,    0xC6, { KEY_VOLUMEDOWN } },              /* Press */
>>       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },              /* Release */
>> -     { KE_SW,     0xC8, { .sw = { SW_ROTATE_LOCK, 1 } } }, /* Press */
>> -     { KE_SW,     0xC9, { .sw = { SW_ROTATE_LOCK, 0 } } }, /* Release */
>> +     { KE_KEY,    0xC8, { KEY_ROTATE_LOCK_TOGGLE } },      /* Press */
>> +     { KE_IGNORE, 0xC9, { KEY_ROTATE_LOCK_TOGGLE } },      /* Release */
>>       { KE_KEY,    0xCE, { KEY_POWER } },                   /* Press */
>>       { KE_IGNORE, 0xCF, { KEY_POWER } },                   /* Release */
>>       { KE_END },
>> --
>> 2.15.1
>>
>>
>
> --
> Darren Hart
> VMware Open Source Technology Center



-- 
Cheers,
Alex Hung



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux