Re: [PATCH v2 12/12] extcon: axp288: Set USB role where necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 25-02-18 19:51, Randy Dunlap wrote:
Hi,

On 02/25/2018 07:25 AM, Hans de Goede wrote:
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index a7bca4207f44..de15bf55895b 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -30,7 +30,8 @@ config EXTCON_ARIZONA
config EXTCON_AXP288
  	tristate "X-Power AXP288 EXTCON support"
-	depends on MFD_AXP20X && USB_PHY
+	depends on MFD_AXP20X && USB_SUPPORT && X86

Could that be:
	depends on MFD_AXP20X && USB_SUPPORT && (X86 || COMPILE_TEST)

or is there some reason that it won't even build on other $ARCH?

It uses:

#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>

So it really should only be build on X86, it always was an X86 only
driver, but it now it really depends on X86.

Thank you for all the reviews. I will prepare a v3 with all your
proposed fixes soon(ish).
Regards,

Hans


+	select USB_ROLE_SWITCH
  	help
  	  Say Y here to enable support for USB peripheral detection
  	  and USB MUX switching by X-Power AXP288 PMIC.

thanks,




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux