Re: [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 22, 2018 at 08:15:51PM +0000, Jeremy Cline wrote:
> On Thu, Feb 22, 2018 at 01:58:42PM -0600, Mario Limonciello wrote:
> > Some laptops such as the XPS 9360 support the intel-vbtn INT33D6
> > interface but don't initialize the bit that intel-vbtn uses to
> > represent switching tablet mode.
> > 
> > By running this only on real 2-in-1's it shouldn't cause false
> > positives.
> > 
> > Fixes: 30323fb6d5 ("Support tablet mode switch")
> > Reported-by: Jeremy Cline <jeremy@xxxxxxxxxx>
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> > ---
> > Note: I also moved the code for detecting tablet into it's own
> > function.  To keep things under 80 lines with if statements was
> > making the code very unreadable otherwise.
> > 
...
> 
> Tested-by: Jeremy Cline <jeremy@xxxxxxxxxx>

Wow, incredible turn around time Mario and Jeremy. Doing some
confirmation on my end, and will queue up to Fixes for 4.16 RC cycle.

-- 
Darren Hart
VMware Open Source Technology Center



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux