On 02/22/2018 05:21 AM, Marco Martin wrote: > On giovedì 22 febbraio 2018 06:14:07 CET Jeremy Cline wrote: >> Hey folks, >> >> Commit 30323fb6d552c41997baca5292bf7001366cab57 (Support tablet mode >> switch) causes the keyboard on my XPS 13 to stop working. This >> particular model has a touch screen (which I've disabled in the BIOS), >> but isn't a 2-in-1 with a tablet mode. My guess is it's being put in >> tablet mode and that's disabling the keyboard? In any case, I'm happy >> to test fixes and provide any necessary information. > > 30323fb6d552c41997baca5292bf7001366cab57 initializes the switch to the correct > state, in theory, it seems VGBS() is returning the wrong thing? could it > report it has the switch and in a closed state even if it doesn't have it? > also seems device specific, on my inspiron6352 if i go in teblet mode the > keyboard keeps working until i fold it completely (which i don't know/don't > think is something detectable at all from the software side) > > can you test with the command evtest (if an external keyboard works, or via > ssh)?, then looking at the state of the intel virtual button driver it should > show you the current state of the switch > Hi, Here's the evtest output for the virtual button driver: Input driver version is 1.0.1 Input device ID: bus 0x19 vendor 0x0 product 0x0 version 0x0 Input device name: "Intel Virtual Button driver" Supported events: Event type 0 (EV_SYN) Event type 1 (EV_KEY) Event code 114 (KEY_VOLUMEDOWN) Event code 115 (KEY_VOLUMEUP) Event code 116 (KEY_POWER) Event code 125 (KEY_LEFTMETA) Event code 240 (KEY_UNKNOWN) Event code 561 (?) Event type 4 (EV_MSC) Event code 4 (MSC_SCAN) Event type 5 (EV_SW) Event code 1 (SW_TABLET_MODE) state 1 Properties: Testing ... (interrupt to exit) Regards, Jeremy