On Wed, Feb 21, 2018 at 5:12 PM, Guillaume Douézan-Grard <gdouezangrard@xxxxxxxxx> wrote: > Hi Andy, > > Thank you for your review. Changes since the previous submission are > highlighted below. > > On Topstar U931/RVP7 Notebooks, an issue prevents the WLAN toggle key > from being properly managed by the Embedded Controller and successfully > disconnect the adapter. A specific ACPI method allows to toggle the WLAN > LED state regardless. > > Based on a DMI check, the LED is registered within the corresponding > subsystem, making possible to use a software-based trigger (rfkill for > instance, to synchronize the LED with the network interface state). > > Thank you for your time, Couple of style things. otherwise looks good to me. > > -- > Guillaume Douézan-Grard > > > Changes since v2: > > * revert an older conversion from a generic module to an acpi driver > module instead of undoing it manually, > * separate commits for the renaming and the spliting phases, > * DMI-based check instead of a module parameter, > * copyright and minor fixes put at the end. > > > Changes since v1: > > * leave devices names unchanged for ABI compatibility, > * fix label names, > * separate module authors definition, > * add commit description to Patch 3. > > > Guillaume Douézan-Grard (6): > revert "topstar-laptop: convert to module_acpi_driver()" > platform/x86: topstar-laptop: use consistent naming scheme > platform/x86: topstar-laptop: split ACPI events and input handling > platform/x86: topstar-laptop: add platform device > platform/x86: topstar-laptop: add Topstar U931/RVP7 WLAN LED > workaround > platform/x86: topstar-laptop: update copyright and fix some comments > > drivers/platform/x86/Kconfig | 2 + > drivers/platform/x86/topstar-laptop.c | 358 +++++++++++++++++++++++++++------- > 2 files changed, 290 insertions(+), 70 deletions(-) > > -- > 2.16.1 > -- With Best Regards, Andy Shevchenko
