On Sun, Feb 11, 2018 at 10:07:20PM +0100, Micha?? K??pie?? wrote: > The patch series contains miscellaneous cleanups which I think are worth > getting done before splitting fujitsu-laptop into two separate modules. > I am not 100% sure that all the changes in the last patch in this series > actually help, so please speak your mind. With the relatively minor comments about patch 6 I've posted about separately, I'm happy with this patch set. Collectively these changes improve the readability of the code and make its intent clearer. > This patch series was tested on a Lifebook S7020. AFAICT it does not > conflict with the recent draft patch from Jan-Marek Glogowski and may > thus be applied independently. I agree. I'm interested to hear your thoughts in connection with my queries about patch 6 before merging. That aside, I have no issues with this series. Reviewed-by: Jonathan Woithe <jwoithe@xxxxxxxxxx> Regards jonathan