> -----Original Message----- > From: platform-driver-x86-owner@xxxxxxxxxxxxxxx [mailto:platform-driver-x86- > owner@xxxxxxxxxxxxxxx] On Behalf Of Laszlo Toth > Sent: Tuesday, February 13, 2018 1:28 PM > To: Matthew Garrett <mjg59@xxxxxxxxxxxxx>; Pali Rohár <pali.rohar@xxxxxxxxx>; > Darren Hart <dvhart@xxxxxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxxxxx>; > platform-driver-x86@xxxxxxxxxxxxxxx; Limonciello, Mario > <Mario_Limonciello@xxxxxxxx> > Subject: [PATCH v2] platform/x86: dell-laptop: fix kbd_get_state's request value > > Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap > rather than globally") > broke one request, changed it back to the original value. > > Tested on a Dell E6540, backlight came back. > > Signed-off-by: Laszlo Toth <laszlth@xxxxxxxxx> > --- > Changes in v2: > - split the fix and the function merge part > > drivers/platform/x86/dell-laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index 2a68f59..a37cff9 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state) > struct calling_interface_buffer buffer; > int ret; > > - dell_fill_request(&buffer, 0, 0, 0, 0); > + dell_fill_request(&buffer, 0x1, 0, 0, 0); > ret = dell_send_request(&buffer, > CLASS_KBD_BACKLIGHT, > SELECT_KBD_BACKLIGHT); > if (ret) > -- > 2.7.4 This should also CC stable and Fixes 9862b43624a5450a097cc4122732857b869dbbca Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
