> -----Original Message----- > From: Ivan Vecera [mailto:ivecera@xxxxxxxxxx] > Sent: Monday, January 22, 2018 4:21 PM > To: platform-driver-x86@xxxxxxxxxxxxxxx > Cc: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; Bjørn Mork <bjorn@xxxxxxx>; > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Subject: [PATCH v3] platform/x86: mlx-platform: fix module aliases > > Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is not loaded > automatically. The driver should use MODULE_DEVICE_TABLE together with > existing mlxplat_dmi_table instead. Darren/Andy, Since mlx-platform is about to be modified in for-next, how to proceed on this patch? Could I resend it based on top of the latest version? > > Changes: > v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn) > v3 - MODULE_DEVICE_TABLE moved after mlxplat_dmi_table declaration > > Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from > arch/x86") > Cc: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: Bjørn Mork <bjorn@xxxxxxx> > Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx> > --- > drivers/platform/x86/mlx-platform.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx- > platform.c > index 504256c3660d..22cd011f6aee 100644 > --- a/drivers/platform/x86/mlx-platform.c > +++ b/drivers/platform/x86/mlx-platform.c > @@ -286,6 +286,8 @@ static const struct dmi_system_id mlxplat_dmi_table[] > __initconst = { > { } > }; > > +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table); > + > static int __init mlxplat_init(void) > { > struct mlxplat_priv *priv; > @@ -370,8 +372,3 @@ module_exit(mlxplat_exit); MODULE_AUTHOR("Vadim > Pasternak (vadimp@xxxxxxxxxxxx)"); MODULE_DESCRIPTION("Mellanox > platform driver"); MODULE_LICENSE("Dual BSD/GPL"); - > MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:"); > -MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:"); > -- > 2.13.6
