On Wed, Jan 31, 2018 at 08:44:20PM +0100, Lukas Wunner wrote:
> On Wed, Jan 31, 2018 at 10:39:25AM -0800, Darren Hart wrote:
> > On Thu, Jan 25, 2018 at 02:38:00PM -0800, Darren Hart wrote:
> > > On Wed, Jan 24, 2018 at 07:35:45PM +0100, Lukas Wunner wrote:
> > > > Commit 4eebd5a4e726 ("apple-gmux: lock iGP IO to protect from vgaarb
> > > > changes") amended this driver's ->probe hook to lock decoding of normal
> > > > (non-legacy) I/O space accesses to the integrated GPU on dual-GPU
> > > > MacBook Pros. The lock stays in place until the driver is unbound.
> > > >
> > > ...
> > > >
> > > > So let's revert commit 4eebd5a4e726 please. Users experiencing the
> > > > issue with the proprietary nvidia driver can comment out the above-
> > > > quoted problematic code as a workaround (or try updating the BIOS).
> > > >
> > > > Cc: Petri Hodju <petrihodju@xxxxxxxxx>
> > > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > > > Cc: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx>
> > > > Cc: Andy Ritger <aritger@xxxxxxxxxx>
> > > > Cc: Ronald Tschalär <ronald@xxxxxxxxxxxxx>
> > >
> > > I presume we'd like to see this applied to linux-stable as well?
> >
> > I haven't heard back
>
> I did reply to your e-mail on Jan 26, quote:
> "Fine by me. Can you add the stable designation when applying or
> would you prefer me to respin?"
>
> https://www.spinics.net/lists/platform-driver-x86/msg14690.html
>
>
> > but from what I've seen in this thread, this appears to me
> > to be in need of porting back to stable releases.
> > I'm pushing this to testing, and then shortly to for-next, and then to Linus.
> > Please let me know if this isn't what everyone is expecting.
>
> WFM, thanks!
>
> Lukas
Sorry for responding slowly to the thread. Yes, if this reintroduces
interaction problems for users of the nvidia proprietary driver, then
commenting out the code you noted may be the best workaround for them
in the short term.
Anyway, the patch, for whichever kernel trees, is Acked-by: Andy Ritger <aritger@xxxxxxxxxx>
