> -----Original Message----- > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > Sent: Thursday, January 25, 2018 11:47 PM > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: andy.shevchenko@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx > Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove > redundant dev_err messages on device_create > > On Wed, Jan 24, 2018 at 08:33:37PM +0000, Vadim Pasternak wrote: > > The upper layer will manage and report errors returned by the create > > and destroy functions. > > > > FIXME: but it doesn't - we don't even check > > I think we agreed to just drop this patch entirely, since this error is not checked > elsewhere? Keeping the dev_err messages? > Yes, we'll keep it. We just had conflict in patch order and I wanted to fix it, staying as much as possible aligned with the top of mellanox v10 branch. However currently we still have a problem in mellanox v11 after patch platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface It dropped parameter device in mlxreg_hotplug_device_create, which is Used inside the routine. I'll send a separate patch to fix it from top of v11. In other case it'll be necessary to fix Modify to use a regmap interface and re-send all from 5-th patch in series. Also we should drop the patch: platform/x86: mlx-platform: Simplify IO access to regmap context It introduced the issue reported by sparse. I am resending two last patches from review-dvhart-mellanox-v11 branch and also patch with fix for mlxreg_hotplug_device_create, as: 0010-platform-x86-mlx-platform-Extend-register-map-config.patch 0011-platform-mellanox-mlxreg-hotplug-Add-check-for-negat.patch 0012-platform-mellanox-mlxreg-hotplug-Fix-issue-of-commit.patch Thank you very much for your help, Vadim. > > > > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > [dvhart: refactored into smaller functional changes] > > Signed-off-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx> > > --- > > drivers/platform/mellanox/mlxreg-hotplug.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c > > b/drivers/platform/mellanox/mlxreg-hotplug.c > > index e55f576..0ccd327 100644 > > --- a/drivers/platform/mellanox/mlxreg-hotplug.c > > +++ b/drivers/platform/mellanox/mlxreg-hotplug.c > > @@ -187,16 +187,11 @@ static int mlxreg_hotplug_device_create(struct > device *dev, > > struct mlxreg_hotplug_device *item) { > > item->adapter = i2c_get_adapter(item->bus); > > - if (!item->adapter) { > > - dev_err(dev, "Failed to get adapter for bus %d\n", > > - item->bus); > > + if (!item->adapter) > > return -EFAULT; > > - } > > > > item->client = i2c_new_device(item->adapter, &item->brdinfo); > > if (!item->client) { > > - dev_err(dev, "Failed to create client %s at bus %d at addr > 0x%02x\n", > > - item->brdinfo.type, item->bus, item->brdinfo.addr); > > i2c_put_adapter(item->adapter); > > item->adapter = NULL; > > return -EFAULT; > > -- > > 2.1.4 > > > > > > -- > Darren Hart > VMware Open Source Technology Center
