On Wed, Jan 24, 2018 at 08:34:55PM +0000, Vadim Pasternak wrote: > Get rid of struct mlxplat_mlxcpld_regmap_context, which contains only the > field with base address. Instead obtain base memory address by > devm_ioport_map to local variable and pass it to devm_regmap_init. > > Modify mlxplat_mlxcpld_reg_read/write to directly use pointer to context > for IO operations. > > Add missed description of pdev_hotplug for struct mlxplat_priv. Separate patch. Keep in mind that if there is a bug, and a patch is reverted - do you want it all reverted together? In this case, the comment is totally unrelated to this change. I've made this change. -- Darren Hart VMware Open Source Technology Center