On Mon, Jan 22, 2018 at 07:49:46PM -0800, Darren Hart wrote: > On Wed, Jan 17, 2018 at 06:21:56PM +0000, Vadim Pasternak wrote: > > +#define MLXREG_CORE_LABEL_MAX_SIZE 32 > > + > > /** > > * struct mlxreg_hotplug_device - I2C device data: > > + * > > * @adapter: I2C device adapter; > > * @client: I2C device client; > > * @brdinfo: device board information; > > * @nr: I2C device adapter number, to which device is to be attached; > > - * @np - pointer to node platform associated with attribute; > > We just added this in 3/4. This should have just been skipped and done as it is > here directly, and only enabling ARM support at the end. Apologies, I was still working on this email when I accidentally sent it instead of postponing it. The above is true, but I'm working on fixing it in my branch. No need to resend at this point. -- Darren Hart VMware Open Source Technology Center