On Mon, Jan 22, 2018 at 3:52 PM, Marco Martin <notmart@xxxxxxxxx> wrote: > On Mon, Jan 22, 2018 at 2:42 PM, Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: >>> + if (obj && obj->type == ACPI_TYPE_INTEGER) { >>> + if (obj->integer.value & TABLET_MODE_FLAG) >>> + input_report_switch(priv->input_dev, >> >>> + SW_TABLET_MODE, >>> + 0); >> >> One line? > > checkpatch.pl was complaining about lines too long. My mailer is using true type fonts, so, I don't see clearly an indentation here, if you already moved SW_ under priv-> that's fine to leave, otherwise, just move one tab left the entire line. -- With Best Regards, Andy Shevchenko