Walter, please, do not shrink Cc list until you sure person / people
in question is/are not interested in the topic.
On Thu, Jan 18, 2018 at 9:21 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jan 18, 2018 at 1:20 PM, walter harms <wharms@xxxxxx> wrote:
>> Am 18.01.2018 12:03, schrieb Dan Carpenter:
>>> On Thu, Jan 18, 2018 at 11:50:30AM +0100, walter harms wrote:
>
>>>>> out_unwind_strings:
>>>>> - for (i = i-1; i > 0; i--) {
>>>>> + for (i = i-1; i >= 0; i--) {
>>>>> kfree(token_location_attrs[i].attr.name);
>>>>> kfree(token_value_attrs[i].attr.name);
>>>>> }
>
>>>> would you mind to reverse order here ?
>>>> you know programmers are terrible at couting backwards.
>>>
>>> I prefer to always unwind in reverse order so I'd prefer to leave it
>>> as-is.
>
>> It is just a comment from my side. we can leave the actual decision to the
>> current maintainer.
>
> Right.
> And maintainer would like to see simple:
>
> while (i--) {
> kfree(token_location_attrs[i].attr.name);
> kfree(token_value_attrs[i].attr.name);
> }
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
