On Tue, Jan 16, 2018 at 08:06:18AM +0000, Vadim Pasternak wrote: > > > > -----Original Message----- > > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > > Sent: Tuesday, January 16, 2018 5:43 AM > > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > Cc: andy.shevchenko@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx > > Subject: Re: [patch v8 1/3] platform/x86: move Mellanox hardware platform > > hotplug driver to platform/mellanox > > > > On Thu, Jan 11, 2018 at 08:58:41AM +0000, Vadim Pasternak wrote: > > > It moves drivers/platform/x86/mlxcpld-hotplug.c to > > > drivers/platform/mellanox/mlxreg-hotplug.c and > > > include/linux/platform_data/mlxcpld-hotplug.h to > > > include/linux/platform_data/mlxreg.h for making hotplug driver usable > > > for the different machine architectures. > > > > > > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > > Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > --- > > > v7->v8: > > > v6->v7: > > > Fixes added by Vadim: > > > - remove dependency on X86_64 to allow also X86 architecture; > > > v5->v6: > > > Fixes added by Vadim: > > > - add SPD license record to Kconfig and Makefile; > > > v4->v5: > > > Comments pointed out by Andy: > > > - arrange MAINTAINERS in correct alphabetic order; > > > v3->v4: > > > Comments pointed out by Darren: > > > - Refactor the patches to provide the changes in patchset in incremental > > > order; > > > - Modify MAINTAINERS records; > > > - Use git-mv for the replaced files; > > > Commnets pointed out by Colin: > > > - Make structures mlxplat_dev and mlxplat_hotplug static; > > > --- > > > > ... > > > > > config MLX_PLATFORM > > > tristate "Mellanox Technologies platform support" > > > - depends on X86_64 > > > > This seems like it would be more appropriately applied to 2/3 as this patch is > > supposed to be just about the renaming of the files, methods, and defines from > > CPLD to reg, and the creation of the mellanox platform. > > > > Any reason this needs to be in this patch? > > > > Hi Darren, > Thank you very much for reviews. > > I removed X86_64 dependency in this patch to allow the driver also for > 32 bit architecture. Ah, right - this is not for ARM, and just for the x86/mlx-platform driver. OK. So, in that case, let's just do this as a separate patch since it is not related to the move in anyway and just confused the issue (or me ;-) -- Darren Hart VMware Open Source Technology Center
