On Wed, Jan 3, 2018 at 10:01 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 03-01-18 00:40, Darren Hart wrote: >> On Tue, Jan 02, 2018 at 07:39:27PM +0100, Paul Cercueil wrote: >> Generally "testing" is the branch you want to base on if linus/master >> doesn't work as the review-* branches *will* rebase frequently. >> Exceptions exist of course, and this patch is just fine - just for >> future reference. > > > This is my "fault", I asked Paul to rebase on top of > review-andy as that had 1 new silead_dmi patches missing > from testing, so otherwise we would end up with a conflict when > merging review branches. Same reason why I've been basing my > silead_dmi patches on top of review-andy even though that is > an unusual base to use. Darren, in this case it's exceptional since there is a stream of a patches against silead_dmi. They appear faster than older appear in testing. -- With Best Regards, Andy Shevchenko