The annoying static analyzer follow up patches sometimes make a pain
rather than fixing issues.
The one done by commit 276c87054751
("x86/platform/intel-mid: Make 'bt_sfi_data' const")
convert the struct to be const while it is used as a temporary container
for important data that is used to fill 'parent' and 'name' fields in
struct platform_device_info.
That's why revert the commit which had been apparently done w/o reading
the code.
Note, compiler doesn't notice this due to explicit cast, which would be
addressed separately.
Cc: Bhumika Goyal <bhumirks@xxxxxxxxx>
Cc: julia.lawall@xxxxxxx
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
v2: low the tone of accusation that this made a regression
arch/x86/platform/intel-mid/device_libs/platform_bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-mid/device_libs/platform_bt.c b/arch/x86/platform/intel-mid/device_libs/platform_bt.c
index dc036e511f48..5a0483e7bf66 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_bt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_bt.c
@@ -60,7 +60,7 @@ static int __init tng_bt_sfi_setup(struct bt_sfi_data *ddata)
return 0;
}
-static const struct bt_sfi_data tng_bt_sfi_data __initdata = {
+static struct bt_sfi_data tng_bt_sfi_data __initdata = {
.setup = tng_bt_sfi_setup,
};
--
2.15.1
