On Sat, Dec 23, 2017 at 10:33 AM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> On Saturday 23 December 2017 02:01:22 Wei Yongjun wrote:
>> Fixes the following sparse warnings:
>>
>> drivers/platform/x86/dell-laptop.c:289:6: warning:
>> symbol 'dell_set_arguments' was not declared. Should it be static?
>> drivers/platform/x86/dell-laptop.c:298:5: warning:
>> symbol 'dell_send_request' was not declared. Should it be static?
>>
Pushed to my review and testing queue, thanks!
>> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>> ---
>> drivers/platform/x86/dell-laptop.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index 629d960..a94936a 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -286,7 +286,7 @@ static int __init dmi_matched(const struct dmi_system_id *dmi)
>> { }
>> };
>>
>> -void dell_set_arguments(u32 arg0, u32 arg1, u32 arg2, u32 arg3)
>> +static void dell_set_arguments(u32 arg0, u32 arg1, u32 arg2, u32 arg3)
>> {
>> memset(buffer, 0, sizeof(struct calling_interface_buffer));
>> buffer->input[0] = arg0;
>> @@ -295,7 +295,7 @@ void dell_set_arguments(u32 arg0, u32 arg1, u32 arg2, u32 arg3)
>> buffer->input[3] = arg3;
>> }
>>
>> -int dell_send_request(u16 class, u16 select)
>> +static int dell_send_request(u16 class, u16 select)
>> {
>> int ret;
>>
>
> This is correct change, add my:
>
> Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxxx>
>
> --
> Pali Rohár
> pali.rohar@xxxxxxxxx
--
With Best Regards,
Andy Shevchenko
