n Tue, Dec 19, 2017 at 5:06 PM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> On Tuesday 19 December 2017 11:38:34 Shih-Yuan Lee (FourDollars) wrote:
>> The Dell Latitude 5495 has the mic mute key.
>>
>> Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@xxxxxxxxxxxxx>
>> ---
>> drivers/platform/x86/dell-wmi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
>> index fb25b20..d40f803 100644
>> --- a/drivers/platform/x86/dell-wmi.c
>> +++ b/drivers/platform/x86/dell-wmi.c
>> @@ -261,6 +261,9 @@ static const u16 bios_to_linux_keycode[256] = {
>> * override them.
>> */
>> static const struct key_entry dell_wmi_keymap_type_0010[] = {
>> + /* Mic mute */
>> + { KE_KEY, 0x150, { KEY_F20 } },
>
> Why F20 for mic mute? We have KEY_MICMUTE.
Because X Window System doesn't support KEY_MICMUTE [1] directly, it
still relies on systemd/udev rule [2] to convert it to KEY_F20 again
in the user space.
So I am also wondering why not using KEY_F20 directly and I am also
thinking about changing the bios_to_linux_keycode's KEY_MICMUTE to
KEY_F20 for compatibility.
[1]: https://bugs.freedesktop.org/show_bug.cgi?id=54171
[2]: https://github.com/systemd/systemd/commit/fc6e082622c73eb9a22ce16a278d8c4dd7594cbb
>
>> +
>> /* Fn-lock */
>> { KE_IGNORE, 0x151, { KEY_RESERVED } },
>>
>
> --
> Pali Rohár
> pali.rohar@xxxxxxxxx
--
Shih-Yuan Lee (FourDollars) | Software Engineer / Debian Developer |
Delivery | Customer Engineering | Devices | Canonical
