Re: [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 18, 2017 at 11:21 AM, Ognjen Galić <smclt30p@xxxxxxxxx> wrote:
> On 16/12/2017, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>> On Sat, Dec 16, 2017 at 9:48 AM, Ognjen Galic <smclt30p@xxxxxxxxx> wrote:
>>> On Sat, Dec 16, 2017 at 01:33:55AM +0100, Rafael J. Wysocki wrote:
>>>> On Fri, Dec 15, 2017 at 5:57 PM, Ognjen Galic <smclt30p@xxxxxxxxx>
>>>> wrote:
>>>> > The EC/ACPI firmware on Lenovo ThinkPads used to report a status
>>>> > of "Unknown" when the battery is between the charge start and
>>>> > charge stop thresholds. On Windows, it reports "Not Charging"
>>>> > so the quirk has been added to also report correctly.
>>>> >
>>>> > Now the "status" attribute returns "Not Charging" when the
>>>> > battery on ThinkPads is not physicaly charging.
>>>> >
>>>> > Tested-by: Kevin Locke <kevin@xxxxxxxxxxxxxxx>
>>>> > Tested-by: Christoph Böhmwalder <christoph@xxxxxxxxxxxxxx>
>>>> > Signed-off-by: Ognjen Galic <smclt30p@xxxxxxxxx>
>>>>
>>>> It doesn't look like this is related to the [1/3] and [3/3], so why do
>>>> you make it part of the series?
>>>>
>>>
>>> I made it the same series because it is practically the same feature
>>> set. Without this patch and with 1/3 and 3/3 applied, there is a bug
>>> where the status attribute would show "Unknown" for a battery that is
>>> between the start and stop thresholds while attached to AC.
>>
>> OK, fair enough.
>>
>> I would reorder it as the first patch in the series, then, because the
>> other two are more related to each other.
>>
>> Thanks,
>> Rafael
>>
>
> Do I really need now to re-order and re-send the whole patchset for it
> to get merged?

I'm not sure I will take anything of it at this time.

Thanks,
Rafael




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux