On Wed, Dec 13, 2017 at 10:30 AM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote: > On Wednesday 13 December 2017 13:53:54 Dhaval Shah wrote: >> Removed Possible unnecessary 'out of memory' message checkpatch warnings. >> Issue found by checkpatch. >> - dev_err(&device->dev, "failed to allocate device data\n"); > > Hi! Any particular reason for removing error message? If you look into drivers/base/dd.c (real_probe() function IIRC) it issues a warning when probe fails with error code. So, basically all error messages in ->probe() are redundant (except maybe those that prints more than error message itself). -- With Best Regards, Andy Shevchenko