Hi Joe, ________________________________________ > From: Joe Perches <joe@xxxxxxxxxxx> > Sent: Wednesday, December 13, 2017 5:55 PM > To: Dhaval Shah; Philippe Ombredanne > Cc: pali.rohar@xxxxxxxxx; Darren Hart; Andy Shevchenko; platform-driver-x86@xxxxxxxxxxxxxxx; LKML > Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines > > On Wed, 2017-12-13 at 10:53 +0000, Dhaval Shah wrote: > > > > This is different issue. If we need to fix the issue of this if we update SPDX licensing as well. > > > > I am agree with you on the use of the new SPDX IDs instead of the long legalese. > > > > For this, we have to add the text "// SPDX-License-Identifier: GPL-2.0" at the top of the file and remove the > > > > whole license part and keep on copyright and Author name related info. After change, it looks like > > > > // SPDX-License-Identifier: GPL-2.0 > > > > /* > > > > * Dell Airplane Mode Switch driver > > > > * Copyright (C) 2014-2015 Pali Rohár <pali.rohar@xxxxxxxxx> > > > > */ > > > > > > And for a short comment block like this, Linus preference is to avoid > > > mixing comment style and go all the way C++ style as in: > > > > > > > // SPDX-License-Identifier: GPL-2.0 > > > > // Dell Airplane Mode Switch driver > > > // Copyright (C) 2014-2015 Pali Rohár <pali.rohar@xxxxxxxxx> > > > > > > ... for even less boilerplate ;) > > > > Thanks a lot for the link. > > Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this > > >patch merge? > > If anyone does conversions of these license texts > you have to be _extremely_ careful about what > specific license identifier you use. > This license includes the text > "or (at your option) any later version" > which is not the same as using > SPDX-License-Identifier: GPL-2.0 I have given this SPDX ID based on the current license info in the driver. Yeah. I give the authority to author pali.rohar@xxxxxxxxx to decide the SPDX text.