On Mon, Dec 11, 2017 at 02:48:23AM +0100, Stefan Brüns wrote: > On Saturday, December 9, 2017 12:07:08 AM CET Darren Hart (VMware) wrote: > > The new notify_handler logic determining if autorelease should be used or > > not is a bit awkward, and can result in more than one call to > > sparse_keymap_report_event for the same event (scancode). The nesting > > and long lines also made it difficult to read. > > > > Simplify the logic by eliminating a level of nesting with a goto and > > always calculate autorelease and val so we can make a single call to > > sparse_keymap_report_event. > > > > Signed-off-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx> > > Cc: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx> > > Cc: AceLan Kao <acelan.kao@xxxxxxxxxxxxx> > > --- > > Note: This is based on top of Stefan's v2 patch series for intel-vbtn, > > currently in my review-dvhart branch. > > > > drivers/platform/x86/intel-vbtn.c | 25 +++++++++++++------------ > > 1 file changed, 13 insertions(+), 12 deletions(-) > > Reviewed-by: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx> > Tested-by: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx> Appreciate you taking the time to review and test, thank you! -- Darren Hart VMware Open Source Technology Center
