On Tue, Nov 21, 2017 at 4:36 PM, Souvik Kumar Chakravarty <souvik.k.chakravarty@xxxxxxxxx> wrote: > Add intel_pmc_gcr_readq API for reading from 64-bit GCR registers. > This API will be called from intel_telemetry. Rename intel_pmc_gcr_read > to more appropriate intel_pmc_gcr_readl. > int intel_pmc_s0ix_counter_read(u64 *data); > -int intel_pmc_gcr_read(u32 offset, u32 *data); > +int intel_pmc_gcr_readl(u32 offset, u32 *data); > +int intel_pmc_gcr_readq(u32 offset, u64 *data); > int intel_pmc_gcr_write(u32 offset, u32 data); > int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val); Ah, I didn't notice that we have a bunch of related functions. >From above it looks like we better to leave read as is and introduce _read64() instead of _readq(). This makes names more clear in case we would need _update64 in the future. Something like below at the end: int intel_pmc_gcr_read(u32 offset, u32 *data); int intel_pmc_gcr_write(u32 offset, u32 data); int intel_pmc_gcr_update(u32 offset, u32 mask, u32 val); +int intel_pmc_gcr_read64(u32 offset, u64 *data); -- With Best Regards, Andy Shevchenko
