On Sun, Oct 29, 2017 at 02:49:56AM -0700, sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> > > This patch adds support for regmap based implementation for GCR > read/write/update APIs. > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> > --- > drivers/platform/x86/Kconfig | 1 + > drivers/platform/x86/intel_pmc_ipc.c | 122 +++++++++++++---------------------- > 2 files changed, 46 insertions(+), 77 deletions(-) > > Changes since v7: > * Fixed style issues. > > Changes since v6: > * None > > Changes since v5: > * None > > Changes since v4: > * None > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 80b8795..45f4e79 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1054,6 +1054,7 @@ config PVPANIC > config INTEL_PMC_IPC > tristate "Intel PMC IPC Driver" > depends on ACPI > + select REGMAP_MMIO > ---help--- > This driver provides support for PMC control on some Intel platforms. > The PMC is an ARC processor which defines IPC commands for communication > diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c > index e36144c..df6af1f 100644 > --- a/drivers/platform/x86/intel_pmc_ipc.c > +++ b/drivers/platform/x86/intel_pmc_ipc.c > @@ -35,6 +35,8 @@ > #include <linux/acpi.h> > #include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/spinlock.h> > +#include <linux/mfd/core.h> You already included that in the previous patch. Thanks, -- heikki