On Tuesday 14 November 2017 13:40:13 Wei Yongjun wrote:
> Fix to return error code -ENOMEM from the kzalloc() error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 549b4930f057 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Looks good,
Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxx>
> ---
> drivers/platform/x86/dell-laptop.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index c4903c5..0a8f359 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -2081,8 +2081,10 @@ static int __init dell_init(void)
> }
>
> buffer = kzalloc(sizeof(struct calling_interface_buffer), GFP_KERNEL);
> - if (!buffer)
> + if (!buffer) {
> + ret = -ENOMEM;
> goto fail_buffer;
> + }
>
> if (quirks && quirks->touchpad_led)
> touchpad_led_init(&platform_device->dev);
>
--
Pali Rohár
pali.rohar@xxxxxxxxx
