On Fri, Nov 17, 2017 at 5:19 PM, <Mario.Limonciello@xxxxxxxx> wrote: > Yes looks good to me. Alienware and Inspiron gaming do share this same interface. > > Acked-by: Mario Limonciello <mario.limonciello@xxxxxxxx> > Thank you, Mario. Pushed to my review and testing queue. >> -----Original Message----- >> From: platform-driver-x86-owner@xxxxxxxxxxxxxxx [mailto:platform-driver-x86- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Andy Shevchenko >> Sent: Friday, November 17, 2017 7:38 AM >> To: Chang Liu <foggy.liu@xxxxxxxxx> >> Cc: dvhart@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Platform Driver >> <platform-driver-x86@xxxxxxxxxxxxxxx>; Limonciello, Mario >> <Mario_Limonciello@xxxxxxxx>; Liu4, Chang <Chang_Liu4@xxxxxxxx> >> Subject: Re: [PATCH] platform/x86 alienware-wmi: lightbar LED support for Dell >> Inspiron 5675. >> >> On Thu, Nov 16, 2017 at 4:35 AM, Chang Liu <foggy.liu@xxxxxxxxx> wrote: >> > Inspiron 5675 lightbar compatible with wmi interface on alienware, >> > the difference lies in the zone number and color control. >> > Add Inspiron 5675 DMI quirks to detect by dmi_check_system. >> >> Mario, do you have any comment on this? >> >> > >> > Signed-off-by: Chang Liu <chang_liu4@xxxxxxxx> >> > --- >> > drivers/platform/x86/alienware-wmi.c | 17 +++++++++++++++++ >> > 1 file changed, 17 insertions(+) >> > >> > diff --git a/drivers/platform/x86/alienware-wmi.c >> b/drivers/platform/x86/alienware-wmi.c >> > index 4eb8e1a..9d7dbd9 100644 >> > --- a/drivers/platform/x86/alienware-wmi.c >> > +++ b/drivers/platform/x86/alienware-wmi.c >> > @@ -68,6 +68,14 @@ struct quirk_entry { >> > >> > static struct quirk_entry *quirks; >> > >> > + >> > +static struct quirk_entry quirk_inspiron5675 = { >> > + .num_zones = 2, >> > + .hdmi_mux = 0, >> > + .amplifier = 0, >> > + .deepslp = 0, >> > +}; >> > + >> > static struct quirk_entry quirk_unknown = { >> > .num_zones = 2, >> > .hdmi_mux = 0, >> > @@ -171,6 +179,15 @@ static const struct dmi_system_id alienware_quirks[] >> __initconst = { >> > }, >> > .driver_data = &quirk_asm201, >> > }, >> > + { >> > + .callback = dmi_matched, >> > + .ident = "Dell Inc. Inspiron 5675", >> > + .matches = { >> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >> > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5675"), >> > + }, >> > + .driver_data = &quirk_inspiron5675, >> > + }, >> > {} >> > }; >> > >> > -- >> > 2.7.4 >> > >> >> >> >> -- >> With Best Regards, >> Andy Shevchenko -- With Best Regards, Andy Shevchenko
