On Tue, Nov 14, 2017 at 6:14 PM, Benjamin Berg <bberg@xxxxxxxxxx> wrote: > On the X1 Yoga 2nd Generation and most likely other notebooks the FLAT > mode is reported. Decode it correctly rather than warning about an > unexpected multi mode status to be reported. If we can't check on all available hardware, better to avoid "doing for all" fixes. I suppose DMI match can help here. It would be nice to hear from Henrique and others as well. > case 4: > - valid_modes = TP_ACPI_MULTI_MODE_LAPTOP | > - TP_ACPI_MULTI_MODE_TABLET | > - TP_ACPI_MULTI_MODE_STAND | > - TP_ACPI_MULTI_MODE_TENT; > - break; The common practice is to put /* fallthrough */ instead. > case 5: > + /* In mode 4, FLAT is not specified as a valid mode. However, > + * it can be seen at least on the X1 Yoga 2nd Generation. > + */ We don't use network subsystem style of comments. > valid_modes = TP_ACPI_MULTI_MODE_LAPTOP | > TP_ACPI_MULTI_MODE_FLAT | > TP_ACPI_MULTI_MODE_TABLET | > TP_ACPI_MULTI_MODE_STAND | > TP_ACPI_MULTI_MODE_TENT; > break; -- With Best Regards, Andy Shevchenko
