-------- Original Message -------- Subject: Re: [PATCH v3] dell-laptop: Fix keyboard led max_brightness property for Dell Latitude E6410 From: Pali Rohár <pali.rohar@xxxxxxxxx> Date: Sat, November 11, 2017 4:12 pm To: Darren Hart <dvhart@xxxxxxxxxxxxx> Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx>, Andy Shevchenko <andy@xxxxxxxxxxxxx>, "Gabriel M. Elder" <gabriel@xxxxxxxxxxxxxx>, Gabriele Mazzotta <gabriele.mzt@xxxxxxxxx>, Mario.Limonciello@xxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx On Thursday 02 November 2017 18:18:43 Darren Hart wrote: > On Thu, Nov 02, 2017 at 09:25:24PM +0100, Pali Rohár wrote: > > This machine reports number of keyboard backlight led levels, instead of > > value of the last led level index. Therefore max_brightness properly needs > > to be subtracted by 1 to match led max_brightness API. > > > > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > Reported-by: Gabriel M. Elder <gabriel@xxxxxxxxxxxxxx> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=196913 > > --- > > Changes since v2: > > * Rename quirk entry to kbd_led_levels_off_1 > > Changes since v1: > > * Update kbd_info.levels at initialization time based on quirk > > --- > > drivers/platform/x86/dell-laptop.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > > index f42159f..7424e53 100644 > > --- a/drivers/platform/x86/dell-laptop.c > > +++ b/drivers/platform/x86/dell-laptop.c > > @@ -49,6 +49,7 @@ > > > > struct quirk_entry { > > u8 touchpad_led; > > + u8 kbd_led_levels_off_1; > > I believe you and Andy agreed to use a boolean type here? I'm going to fix this and other entries to boolean type in another patch. -- Pali Rohár pali.rohar@xxxxxxxxx -------- End Original Message -------- If necessary, I am willing to test whatever final proposed patch the community recommends, settles on, and accepts. Would you all like me to test the v3 patch as well? Or are we calling it good at this point, and can expect this to be merged into a final stable kernel release sometime soon? I must admit, I'm looking forward to officially making this bug go bye-bye! - Gabriel
