On Friday, November 10, 2017 12:40:33 AM CET Bastien Nocera wrote: > On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > > The Lenovo Helix 2 and Dell XPS 12 (9Q33) have an extra button on the > > front showing a 'Windows' logo, both reporting event codes 0xC2/0xC3 > > on press/release. On the Dell, both press/release are distinct events > > while on the Helix 2 both events are generated on release. > > > > Tested on XPS 12, for info on the Helix 2 see: > > https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html > > > > Signed-off-by: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx> > > Same problem as mentioned in patch 3. Pretty sure you need to set the > Windows key release to KEY_IGNORE. > > Or better, teach the intel-vbtn driver which buttons should be > autoreleased, and which ones should send key presses and key releases > separately. This would allow handling long presses in the upper layers. First, I explicitly mentioned on the XPS 12, press/release are distinct events. Care to read? Second, if you read patch 2/5, you see support for press/release vs autorelease. Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019
Attachment:
signature.asc
Description: This is a digitally signed message part.
