On 11/07/2017 10:47 AM, Jarkko Sakkinen wrote: > On Mon, Nov 06, 2017 at 07:54:00AM -0800, Dave Hansen wrote: >> On 10/10/2017 07:32 AM, Jarkko Sakkinen wrote: >>> +static LIST_HEAD(sgx_free_list); >>> +static DEFINE_SPINLOCK(sgx_free_list_lock); >> >> Is this a global list? Will this be a scalability problem on larger >> systems? > > It will be need to be refined for NUMA. > > In addition, per-CPU caches would probably make sense. > > For simplicity, I would keep it as it is up until the driver is in the > mainline. FWIW, I don't think we should merge things that aren't performant. Global locks like this are just intolerable. You can add this as a later patch, but please don't merge stuff like this.
