On Thu, Nov 02, 2017 at 12:48:35PM -0700, Sean Christopherson wrote: > On Tue, 2017-10-10 at 17:32 +0300, Jarkko Sakkinen wrote: > > +static int __init sgx_drv_init(void) > > +{ > > + int ret; > > + > > + ret = sgx_drv_subsys_init(); > > The return value of sgx_drv_subsys_init is being ignored. > > > + > > + ret = platform_driver_register(&sgx_drv); > > + if (ret) > > + sgx_drv_subsys_exit(); > > + > > + return ret; > > +} > > +module_init(sgx_drv_init); > > + > > +static void __exit sgx_drv_exit(void) > > +{ > > + platform_driver_unregister(&sgx_drv); > > + sgx_drv_subsys_exit(); > > +} > > +module_exit(sgx_drv_exit); Holds still for v4. the latest version under review. Thanks. /Jarkko