On Thu, Nov 02, 2017 at 09:25:24PM +0100, Pali Rohár wrote: > This machine reports number of keyboard backlight led levels, instead of > value of the last led level index. Therefore max_brightness properly needs > to be subtracted by 1 to match led max_brightness API. > > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx> > Reported-by: Gabriel M. Elder <gabriel@xxxxxxxxxxxxxx> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=196913 > --- > Changes since v2: > * Rename quirk entry to kbd_led_levels_off_1 > Changes since v1: > * Update kbd_info.levels at initialization time based on quirk > --- > drivers/platform/x86/dell-laptop.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index f42159f..7424e53 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -49,6 +49,7 @@ > > struct quirk_entry { > u8 touchpad_led; > + u8 kbd_led_levels_off_1; I believe you and Andy agreed to use a boolean type here? -- Darren Hart VMware Open Source Technology Center
