On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote: > > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: > >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote: > >> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > >> > > >> > Variable byte_data is being initialized and re-assigned with values that > >> > are never read. Remove these as these redundant assignments. Cleans up > >> > clang warning: > >> > > >> > drivers/platform/x86/dell-smo8800.c:106:2: warning: Value stored to 'byte_data' > >> > is never read > >> > >> Thanks for the patch. > >> > >> As I read a code it was from the beginning like this. I dunno what was > >> a motivation of this pieces, thus I would like to hear Pali. > > > > IIRC this part of code comes from the lis3lv* driver which was used for > > HP EliteBook machines. As both drivers provides similar interface for > > userspace. > > OK, though it doesn't clarify the intention of the byte_data > (useless?) assignments. Probably similar code pattern exists in that lis3lv* driver... -- Pali Rohár pali.rohar@xxxxxxxxx
