tree: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git review-andy
head: e9edfd6ef7853975408d391dd3455fd9c9908e66
commit: a5e50220edbdd1ec8912c191a0f5272d629743bf [4/20] platform/x86: intel_telemetry: cleanup redundant headers
config: x86_64-randconfig-ws0-10301422 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
git checkout a5e50220edbdd1ec8912c191a0f5272d629743bf
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the platform-drivers-x86/review-andy HEAD e9edfd6ef7853975408d391dd3455fd9c9908e66 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
>> drivers/platform/x86/intel_telemetry_pltdrv.c:900:3: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
timestamp_prev = readq(unit_config->regmap);
^
drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telemetry_pltdrv_probe':
>> drivers/platform/x86/intel_telemetry_pltdrv.c:1165:2: error: implicit declaration of function 'ioremap_nocache' [-Werror=implicit-function-declaration]
telm_conf->pss_config.regmap = ioremap_nocache(
^
drivers/platform/x86/intel_telemetry_pltdrv.c:1165:31: warning: assignment makes pointer from integer without a cast [enabled by default]
telm_conf->pss_config.regmap = ioremap_nocache(
^
drivers/platform/x86/intel_telemetry_pltdrv.c:1173:32: warning: assignment makes pointer from integer without a cast [enabled by default]
telm_conf->ioss_config.regmap = ioremap_nocache(
^
>> drivers/platform/x86/intel_telemetry_pltdrv.c:1202:3: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
iounmap(telm_conf->pss_config.regmap);
^
cc1: some warnings being treated as errors
vim +/readq +900 drivers/platform/x86/intel_telemetry_pltdrv.c
9d16b482 Souvik Kumar Chakravarty 2016-01-12 884
9d16b482 Souvik Kumar Chakravarty 2016-01-12 885 static int telem_evtlog_read(enum telemetry_unit telem_unit,
9d16b482 Souvik Kumar Chakravarty 2016-01-12 886 struct telem_ssram_region *ssram_region, u8 len)
9d16b482 Souvik Kumar Chakravarty 2016-01-12 887 {
9d16b482 Souvik Kumar Chakravarty 2016-01-12 888 struct telemetry_unit_config *unit_config;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 889 u64 timestamp_prev, timestamp_next;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 890 int ret, index, timeout = 0;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 891
9d16b482 Souvik Kumar Chakravarty 2016-01-12 892 ret = telem_get_unitconfig(telem_unit, &unit_config);
9d16b482 Souvik Kumar Chakravarty 2016-01-12 893 if (ret < 0)
9d16b482 Souvik Kumar Chakravarty 2016-01-12 894 return ret;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 895
9d16b482 Souvik Kumar Chakravarty 2016-01-12 896 if (len > unit_config->ssram_evts_used)
9d16b482 Souvik Kumar Chakravarty 2016-01-12 897 len = unit_config->ssram_evts_used;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 898
9d16b482 Souvik Kumar Chakravarty 2016-01-12 899 do {
9d16b482 Souvik Kumar Chakravarty 2016-01-12 @900 timestamp_prev = readq(unit_config->regmap);
9d16b482 Souvik Kumar Chakravarty 2016-01-12 901 if (!timestamp_prev) {
9d16b482 Souvik Kumar Chakravarty 2016-01-12 902 pr_err("Ssram under update. Please Try Later\n");
9d16b482 Souvik Kumar Chakravarty 2016-01-12 903 return -EBUSY;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 904 }
9d16b482 Souvik Kumar Chakravarty 2016-01-12 905
9d16b482 Souvik Kumar Chakravarty 2016-01-12 906 ssram_region->start_time = readq(unit_config->regmap +
9d16b482 Souvik Kumar Chakravarty 2016-01-12 907 TELEM_SSRAM_STARTTIME_OFFSET);
9d16b482 Souvik Kumar Chakravarty 2016-01-12 908
9d16b482 Souvik Kumar Chakravarty 2016-01-12 909 for (index = 0; index < len; index++) {
9d16b482 Souvik Kumar Chakravarty 2016-01-12 910 ssram_region->events[index] =
9d16b482 Souvik Kumar Chakravarty 2016-01-12 911 readq(unit_config->regmap + TELEM_SSRAM_EVTLOG_OFFSET +
9d16b482 Souvik Kumar Chakravarty 2016-01-12 912 BYTES_PER_LONG*index);
9d16b482 Souvik Kumar Chakravarty 2016-01-12 913 }
9d16b482 Souvik Kumar Chakravarty 2016-01-12 914
9d16b482 Souvik Kumar Chakravarty 2016-01-12 915 timestamp_next = readq(unit_config->regmap);
9d16b482 Souvik Kumar Chakravarty 2016-01-12 916 if (!timestamp_next) {
9d16b482 Souvik Kumar Chakravarty 2016-01-12 917 pr_err("Ssram under update. Please Try Later\n");
9d16b482 Souvik Kumar Chakravarty 2016-01-12 918 return -EBUSY;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 919 }
9d16b482 Souvik Kumar Chakravarty 2016-01-12 920
9d16b482 Souvik Kumar Chakravarty 2016-01-12 921 if (timeout++ > TELEM_SSRAM_READ_TIMEOUT) {
9d16b482 Souvik Kumar Chakravarty 2016-01-12 922 pr_err("Timeout while reading Events\n");
9d16b482 Souvik Kumar Chakravarty 2016-01-12 923 return -EBUSY;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 924 }
9d16b482 Souvik Kumar Chakravarty 2016-01-12 925
9d16b482 Souvik Kumar Chakravarty 2016-01-12 926 } while (timestamp_prev != timestamp_next);
9d16b482 Souvik Kumar Chakravarty 2016-01-12 927
9d16b482 Souvik Kumar Chakravarty 2016-01-12 928 ssram_region->timestamp = timestamp_next;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 929
9d16b482 Souvik Kumar Chakravarty 2016-01-12 930 return len;
9d16b482 Souvik Kumar Chakravarty 2016-01-12 931 }
9d16b482 Souvik Kumar Chakravarty 2016-01-12 932
:::::: The code at line 900 was first introduced by commit
:::::: 9d16b482b059d784137881f3ec4bb121c5a2e6ee platform:x86: Add Intel telemetry platform driver
:::::: TO: Souvik Kumar Chakravarty <souvik.k.chakravarty@xxxxxxxxx>
:::::: CC: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
