On Fri, Oct 27, 2017 at 6:52 PM, <Mario.Limonciello@xxxxxxxx> wrote: >> and there is a new interface to deal with this kind of requirement, serdev. >> But serdev is introduced after v4.12, to make it work before serdev, I >> can't find other good solutions for it. > > Right, I know you have a need for this to work on older kernel too, so I think > this interface as you did it makes sense on older kernel, but please do use serdev > on newer kernel and as this is upstreamed. Exactly, we don't care about old kernels in a new code. >> >> + /* unregister acpi backlight interface */ >> >> + acpi_video_set_dmi_backlight_type(acpi_backlight_vendor); >> > >> > Since you change this when the driver is loaded, you should cache the old >> > value and restore it when the driver is unloaded too. >> >> In this case, acpi backlight doesn't work, all the backlight >> operations would go through UART commands. >> So, it safe to remove it. > > OK. > I think it would be good to include a command about this so that folks who > look at this later understand this. s/command/comment/ I suppose. -- With Best Regards, Andy Shevchenko
