From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
Hi All,
Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers implements the same IPC features.
This code duplication could be avoided if we implement the IPC driver as a generic library and let custom
device drivers use API provided by generic driver. This patchset mainly addresses this issue.
Along with above code duplication issue, This patchset also addresses following issues in intel_pmc_ipc and
intel_punit_ipc drivers.
1. Intel_pmc_ipc.c driver does not use any resource managed (devm_*) calls.
2. In Intel_pmc_ipc.c driver, dependent devices like PUNIT, Telemetry and iTCO are created manually and uses lot of redundant buffer code.
3. Global variable is used to store the IPC device structure and it is used across all functions in intel_pmc_ipc.c and intel_punit_ipc.c.
More info on Intel IPC device library:
-------------------------------------
A generic Intel IPC class driver has been implemented and all common IPC helper functions has been moved to this driver. It exposes APIs to create IPC device channel, send raw IPC command and simple IPC commands. It also creates device attribute to send IPC command from user space.
API for creating a new IPC channel device is,
struct intel_ipc_dev *devm_intel_ipc_dev_create(struct device *dev, const char *devname, struct intel_ipc_dev_cfg *cfg, struct intel_ipc_dev_ops *ops)
The IPC channel drivers (PUNIT/PMC/SCU) when creating a new device can configure their device params like register mapping, irq, irq-mode, channel type,etc using intel_ipc_dev_cfg and intel_ipc_dev_ops arguments. After a new IPC channel device is created, IPC users can use the generic APIs to make IPC calls.
For example, after using this new model, IPC call to PMC device will look like,
pmc_ipc_dev = intel_ipc_dev_get(INTEL_PMC_IPC_DEV);
ipc_dev_raw_cmd(pmc_ipc_dev, ipc_raw_cmd);
intel_ipc_dev_put(pmc_ipc_dev);
I am still testing the driver in different products. But posted it to get some early comments. I also welcome any PMC/PUNIT driver users to check these patches in their product.
Changes since v5:
* Added intel_ipc_cmd and intel_ipc_raw_cmd structures.
* Fixed some minor style issues.
* Rebased "intel_pmc_ipc: Use devm_* calls in driver probe function" patch on top of
4.14-rc5 kernel.
Changes since v4:
* Pushed "platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR update" patch
to the top of the patch list. Also its rebased on top of Andy's review branch.
Changes since v3:
* Rebased on top of Andy's review branch.
* Fixed resource ioremap warning in intel_punit_ipc.c.
* Divided "platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates" patch
into two patches. One fixing the existing issue and another to add regmap support.
* Fixed error in resource initalization logic in ipc_create_punit_device.
* Changed PLATFORM_DEVID_AUTO to PLATFORM_DEVID_NONE in mfd device creation.
* Added unique name to PUNIT BIOS, GTD, & ISP regmaps.
* Fixed NULL pointer exception in intel_ipc_dev_get().
* In intel_ipc_dev.c,
* Fixed error in check for duplicate intel_ipc_dev.
* Added custom interrupt handler support.
* Used char array for error string conversion.
* Added put dev support.
Changes since v2:
* Refactored intel_scu_ipc.c to use generic IPC device APIs.
* Fixed intel_pmc_ipc.c to use pcim_* device managed functions.
Changes since v1:
* Merged devm_* changes in pmc_plat_probe and pmc_pci_probe functions into a
single patch.
* Addressed Andy's comment about keeping the library generic by not implementing
the low level reg access calls in intel_ipc_dev.c. This version will start using
the regmap pointer provided by channel drivers instead of fixed memory map.
* Removed custom IPC APIs in intel_pmc_ipc.c and intel_punit_ipc.c.
* Cleaned up IPC driver users to use APIs provided by generic library (intel_ipc_dev.c).
Kuppuswamy Sathyanarayanan (9):
platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates
platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe function
platform/x86: intel_punit_ipc: Fix resource ioremap warning
platform/x86: intel_pmc_ipc: Use MFD framework to create dependent
devices
platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates
platform: x86: Add generic Intel IPC driver
platform/x86: intel_punit_ipc: Use generic intel ipc device calls
platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls
platform/x86: intel_scu_ipc: Use generic Intel IPC device calls
arch/x86/include/asm/intel_pmc_ipc.h | 31 +-
arch/x86/include/asm/intel_punit_ipc.h | 125 ++--
arch/x86/include/asm/intel_scu_ipc.h | 10 +-
arch/x86/platform/intel-mid/intel-mid.c | 15 +-
drivers/mfd/intel_soc_pmic_bxtwc.c | 37 +-
drivers/platform/x86/Kconfig | 11 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/intel_ipc_dev.c | 565 ++++++++++++++
drivers/platform/x86/intel_pmc_ipc.c | 952 +++++++++---------------
drivers/platform/x86/intel_punit_ipc.c | 307 +++-----
drivers/platform/x86/intel_scu_ipc.c | 487 +++++-------
drivers/platform/x86/intel_telemetry_pltdrv.c | 229 +++---
drivers/rtc/rtc-mrst.c | 16 +-
drivers/watchdog/intel-mid_wdt.c | 18 +-
drivers/watchdog/intel_scu_watchdog.c | 23 +-
include/linux/mfd/intel_soc_pmic.h | 2 +
include/linux/platform_data/x86/intel_ipc_dev.h | 246 ++++++
17 files changed, 1752 insertions(+), 1323 deletions(-)
create mode 100644 drivers/platform/x86/intel_ipc_dev.c
create mode 100644 include/linux/platform_data/x86/intel_ipc_dev.h
--
2.7.4
