On Monday 09 October 2017 17:51:51 Mario Limonciello wrote: > + /* make sure we're not calling a higher instance than exists*/ > + if (_IOC_NR(cmd) > wblock->gblock.instance_count - 1) > + return -EINVAL; Is this condition really working? instance_count is unsigned, cmd is also unsigned... and when instance_count is zero, then IIRC error would not be thrown. -- Pali Rohár pali.rohar@xxxxxxxxx