On 09/10/17 13:21:17 +0300, Andy Shevchenko wrote: > On Mon, Oct 9, 2017 at 1:57 AM, Christos Gkekas <chris.gekas@xxxxxxxxx> wrote: > > A couple of macros are unused and need to be removed. > > Also variable percent is unsigned so checking whether it is less than > > zero is redundant. > > > -#define OT_EC_CAMERA_MASK (1 << 0) > > #define OT_EC_BT_MASK (1 << 1) > > #define OT_EC_GPS_MASK (1 << 2) > > #define OT_EC_WIFI_MASK (1 << 3) > > #define OT_EC_WWAN_MASK (1 << 4) > > -#define OT_EC_TS_MASK (1 << 5) > > While they are unused they won't bring any additional code to the binary. > The rationale to leave them is to have a bit descriptions in the code, > so, anyone who is in possession of that old and rare hardware can do > some tests or amendments without searching looking to documentation. > > > > - if (percent < 0 || percent > OT_EC_BL_BRIGHTNESS_MAX) > > + if (percent > OT_EC_BL_BRIGHTNESS_MAX) > > return -EINVAL; > > While it's true, doesn't compiler take care about that? > > https://lkml.org/lkml/2006/11/28/206 > > So, unfortunately I have no reason to take it. > > -- > With Best Regards, > Andy Shevchenko Fair enough, thanks for your time and feedback. Regards, Christos
