On Sun, Oct 8, 2017 at 6:48 PM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sat, Oct 7, 2017 at 7:59 AM, Mario Limonciello > <mario.limonciello@xxxxxxxx> wrote: >> This splits up the dell-smbios driver into two drivers: >> * dell-smbios >> * dell-smbios-smm >> >> dell-smbios can operate with multiple different dispatcher drivers to >> perform SMBIOS operations. >> >> Also modify the interface that dell-laptop and dell-wmi use align to this >> model more closely. Rather than a single global buffer being allocated >> for all drivers, each driver will allocate and be responsible for it's own >> buffer. The pointer will be passed to the calling function and each >> dispatcher driver will then internally copy it to the proper location to >> perform it's call. > >> config DELL_SMBIOS >> tristate > >> + depends on DELL_SMBIOS_SMM >> + > > If the above dependency is true (which I'm quite sure not) this split > should never happen. Hmm... One more thought here. Which is library and which is not? IOW the question is "can DELL_SMBIOS be a standalone working module"? > >> +config DELL_SMBIOS_SMM >> + tristate "Dell SMBIOS calling interface (SMM implementation)" >> + depends on DCDBAS >> + default DCDBAS >> + select DELL_SMBIOS >> ---help--- >> + This provides an implementation for the Dell SMBIOS calling interface >> + communicated over SMI/SMM. >> >> + If you have a Dell computer from <=2017 you should say Y or M here. >> + If you aren't sure and this module doesn't work for your computer >> + it just won't load. -- With Best Regards, Andy Shevchenko
